[illink] Turn on serialization discovery in .NET 7 #15676
Comments
|
Fixed here: 62055c5 |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this issue
Aug 19, 2022
* Update dependencies from https://github.com/dotnet/installer build 20220807.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22407.1 * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220808.5 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22408.5 * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220809.23 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22409.23 * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220810.15 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22410.15 * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220812.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22412.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.AspNetCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2 (parent: Microsoft.Dotnet.Sdk.Internal * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 2022081.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22413.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.AspNetCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22412.1 (parent: Microsoft.Dotnet.Sdk.Internal * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220814.7 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22414.7 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.AspNetCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22412.1 (parent: Microsoft.Dotnet.Sdk.Internal * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220816.2 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.1.22416.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.AspNetCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22415.1 (parent: Microsoft.Dotnet.Sdk.Internal * Re-generate global.json * Update dependencies from https://github.com/dotnet/installer build 20220817.1 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22405.9 -> To Version 7.0.100-rc.2.22417.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.AspNetCore.App.Ref From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22415.4 (parent: Microsoft.Dotnet.Sdk.Internal * Re-generate global.json * [dotnet] Include the 'marshal-ilgen' component. Fixes dotnet#15668. Fixes dotnet#15668. * [dotnet] Enable serialization discovery in the linker. Fixes dotnet#15676. Fixes dotnet#15676. * [tests] Make the dont link tests actually not link for macOS. * [tests] The 'trimmode copy' test needs an adjustment after recent linker changes. * [dotnet] Don't set a default 'TrimMode' value. We already compute a TrimMode value depending on other properties (MtouchLink/LinkMode - or a default value if those aren't set), and the logic to compute the default value is not executed if we set a TrimMode default (because TrimMode overrides any MtouchLink/LinkMode values). * [tests] Workaround a bug in 'dotnet build'. Workaround a bug in 'dotnet build' where escaping semicolons interferes with our ability to pass RuntimeIdentifiers to the build on the command line. * [dotnet] Update expected bundle contents according to updated runtime. * [tests] Update expected error message texts. * Bump to RC 2. Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne
added a commit
that referenced
this issue
Aug 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
dotnet/linker#2929 made serialization heuristics opt-in. To preserve the .NET 6 behavior, the Xamarin SDK should opt in to the old behavior by setting
<_ExtraTrimmerArgs>--enable-serialization-discovery</_ExtraTrimmerArgs>. This can be done once using an SDK with dotnet/sdk#26993 (which will be part of rc1).The text was updated successfully, but these errors were encountered: