Skip to content

Commit

Permalink
[xtro] Fix xtro on dotnet. (#14559)
Browse files Browse the repository at this point in the history
Use the workloads versions to point to the correct dll path when running in a diff bot than the one were the build was done.
  • Loading branch information
mandel-macaque authored Mar 30, 2022
1 parent 3b28219 commit e5b8b19
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/xtro-sharpie/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ $(XMACCATALYST_PCH): .stamp-check-sharpie
$(CORETELEPHONY_HEADERS) \

define DotNetAssembly
ifdef TESTS_USE_SYSTEM
X$(2)_DOTNET ?= $(DOTNET_DIR)/packs/Microsoft.$(1).Runtime.$(X$(2)_RID)/$($(2)_WORKLOAD_VERSION)/runtimes/$(X$(2)_RID)/lib/$(DOTNET_TFM)/$(DOTNET_$(2)_ASSEMBLY_NAME).dll
else
X$(2)_DOTNET ?= $(DOTNET_DESTDIR)/Microsoft.$(1).Runtime.$(X$(2)_RID)/runtimes/$(X$(2)_RID)/lib/$(DOTNET_TFM)/$(DOTNET_$(2)_ASSEMBLY_NAME).dll
endif

dotnet-$(1)-$($(2)_SDK_VERSION).g.cs: .stamp-check-sharpie
$$(SHARPIE) query -bind $$(X$(2)_PCH) > $$@
Expand Down
1 change: 1 addition & 0 deletions tools/devops/automation/templates/build/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ steps:
echo "Rollback file contents:"
echo "$(cat $WORKLOAD_DST)"
name: workload_file
displayName: 'Generate "WorkloadRollback.json'
# upload each of the pkgs into the pipeline artifacts
Expand Down
17 changes: 17 additions & 0 deletions tools/devops/automation/templates/tests/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,23 @@ steps:
displayName: Bootstrap dotnet
timeoutInMinutes: 30

- pwsh: |
$workloadPath = "$(Build.SourcesDirectory)/artifacts/package-internal/WorkloadRollback.json"
$versionData = Get-Content $workloadPath | ConvertFrom-Json
# could be done in a loop, but we don't want to be smart just yet
$iOSVersion = $versionData | Select-Object -ExpandProperty "microsoft.net.sdk.ios"
Write-Host "##vso[task.setvariable variable=IOS_WORKLOAD_VERSION;]$iOSVersion"
$tvOSVersion = $versionData | Select-Object -ExpandProperty "microsoft.net.sdk.tvos"
Write-Host "##vso[task.setvariable variable=TVOS_WORKLOAD_VERSION;]$tvOSVersion"
$macVersion = $versionData | Select-Object -ExpandProperty "microsoft.net.sdk.macos"
Write-Host "##vso[task.setvariable variable=MACOS_WORKLOAD_VERSION;]$macVersion"
$catalystVersion = $versionData | Select-Object -ExpandProperty "microsoft.net.sdk.maccatalyst"
Write-Host "##vso[task.setvariable variable=MACCATALYST_WORKLOAD_VERSION;]$catalystVersion"
displayName: 'Set workload versions for xtro'

- bash: |
set -x
set -e
Expand Down

3 comments on commit e5b8b19

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Catalina (10.15) ✅

Tests passed

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
[xtro] Fix xtro on dotnet. (#14559)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests timed out on macOS M1 - Mac Big Sur (11.5) ❌

Pipeline on Agent
[xtro] Fix xtro on dotnet. (#14559)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found.

Pipeline on Agent XAMBOT-1039.Monterey
[xtro] Fix xtro on dotnet. (#14559)

Please sign in to comment.