Skip to content

Commit

Permalink
[monotouch-test] Make NetworkReachabilityTest.CtorIPAddressPair a bit…
Browse files Browse the repository at this point in the history
… more permissive. Fixes xamarin/maccore#2047. (#7516)

Try to fix xamarin/maccore#2047 by making the test
accept NetworkReachabilityFlags.Reachable for the loopback address on device.

Fixes xamarin/maccore#2047.
  • Loading branch information
rolfbjarne authored Dec 2, 2019
1 parent 845e757 commit bc67353
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,10 @@ public void CtorIPAddressPair ()

Assert.IsTrue (nr.TryGetFlags (out flags), "#1");
// using Loopback iOS 10 / tvOS 10 returns no flags (0) on devices
// but only sometimes... so check for Reachable as well (as a flag).
#if !MONOMAC
if ((Runtime.Arch == Arch.DEVICE) && TestRuntime.CheckXcodeVersion (8, 0))
Assert.That ((int)flags, Is.EqualTo (0), "#1 Reachable");
Assert.That ((flags == (NetworkReachabilityFlags) 0) || ((flags & NetworkReachabilityFlags.Reachable) == NetworkReachabilityFlags.Reachable) , $"#1 Reachable: {flags.ToString ()}");
else
#endif
Assert.That (flags, Is.EqualTo (NetworkReachabilityFlags.Reachable), "#1 Reachable");
Expand Down

5 comments on commit bc67353

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Device tests passed on iOS32b on Azure DevOps(iOS32b): Html Report

No tests selected.

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on bc67353 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 163 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

Failure analysis

Final verdict: 🤥

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on bc67353 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥

Test results

7 tests failed, 106 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Failed
  • link all/iOS Unified 64-bits - device/Release: TimedOut
  • link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): TimedOut
  • link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): TimedOut
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Release: TimedOut
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): TimedOut
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): TimedOut

Failure analysis

Final verdict: 😡 (#7509 is a severe regression)

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on bc67353 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥

Test results

18 tests failed, 95 tests passed.

Failed tests

  • monotouch-test/tvOS - device/Debug: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • monotouch-test/tvOS - device/Release: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
  • monotouch-test/tvOS - device/Debug (dynamic registrar): Failed
  • monotouch-test/tvOS - device/Release (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug: SGenConc: Failed
  • monotouch-test/tvOS - device/Debug (interpreter): Failed
  • monotouch-test/tvOS - device/Debug (interpreter -mscorlib): Failed
  • monotouch-test/tvOS - device/Release (interpreter -mscorlib): Failed
  • link all/tvOS - device/Release: TimedOut
  • link all/tvOS - device/AssemblyBuildTarget: SDK framework (release): TimedOut
  • [NUnit] Mono BCL tests group 2/tvOS - device/Release: TimedOut (MT1032: This application executable might be too large (984 MB) to execute on device. If bitcode was enabled you might want to disable it for development, it is only required to submit applications to Apple.)
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: SDK framework (release): TimedOut

Failure analysis

Final verdict: 😡 (#7509 is a severe regression)

@rolfbjarne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting state to success where context is continuous-integration/jenkins/branch.

Only 🤥 (gred) issues found.

Please sign in to comment.