Skip to content

Commit

Permalink
[monotouch-test] Make NetworkReachabilityTest.CtorIPAddressPair a bit…
Browse files Browse the repository at this point in the history
… more permissive. Fixes xamarin/maccore#2047. (#7521)

Try to fix xamarin/maccore#2047 by making the test
accept NetworkReachabilityFlags.Reachable for the loopback address on device.

Fixes xamarin/maccore#2047.
  • Loading branch information
monojenkins authored and rolfbjarne committed Dec 2, 2019
1 parent 2c02cf7 commit 74a94c3
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,10 @@ public void CtorIPAddressPair ()

Assert.IsTrue (nr.TryGetFlags (out flags), "#1");
// using Loopback iOS 10 / tvOS 10 returns no flags (0) on devices
// but only sometimes... so check for Reachable as well (as a flag).
#if !MONOMAC
if ((Runtime.Arch == Arch.DEVICE) && TestRuntime.CheckXcodeVersion (8, 0))
Assert.That ((int)flags, Is.EqualTo (0), "#1 Reachable");
Assert.That ((flags == (NetworkReachabilityFlags) 0) || ((flags & NetworkReachabilityFlags.Reachable) == NetworkReachabilityFlags.Reachable) , $"#1 Reachable: {flags.ToString ()}");
else
#endif
Assert.That (flags, Is.EqualTo (NetworkReachabilityFlags.Reachable), "#1 Reachable");
Expand Down

2 comments on commit 74a94c3

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 74a94c3 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 163 tests passed.

Failed tests

  • mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Failure analysis

Final verdict: 🤥

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 74a94c3 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS-Beta on Azure DevOps(TvOS-Beta): Html Report 🔥

Test results

23 tests failed, 90 tests passed.

Failed tests

  • monotouch-test/tvOS - device/Debug: Failed
  • [NUnit] Mono BCL tests group 2/tvOS - device/Debug: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • monotouch-test/tvOS - device/Release: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
  • monotouch-test/tvOS - device/Debug (dynamic registrar): Failed
  • monotouch-test/tvOS - device/Release (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug: SGenConc: Failed
  • monotouch-test/tvOS - device/Debug (interpreter): Failed
  • monotouch-test/tvOS - device/Debug (interpreter -mscorlib): Failed
  • monotouch-test/tvOS - device/Release (interpreter -mscorlib): Failed
  • link sdk/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • [NUnit] Mono BCL tests group 1/tvOS - device/Release: Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: dylib (debug): Failed
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • [NUnit] Mono BCL tests group 2/tvOS - device/Release: Failed (MT1032: This application executable might be too large (984 MB) to execute on device. If bitcode was enabled you might want to disable it for development, it is only required to submit applications to Apple.)
  • [NUnit] Mono BCL tests group 2/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed

Failure analysis

Final verdict: 🤥

Please sign in to comment.