Skip to content

Commit

Permalink
[tests] Adjust logic to find MSBuild items after the last MSBuild.Str…
Browse files Browse the repository at this point in the history
…ucturedLogger update.
  • Loading branch information
rolfbjarne committed Jun 1, 2021
1 parent 6582a5a commit 5383e31
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions tests/msbuild/Xamarin.MacDev.Tests/TestHelpers/BuildEngine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,20 @@ public MSBuildItem [] GetItems (ProjectPaths project, string name)
var rv = new List<MSBuildItem> ();

// Items inside ItemGroups
var items = build.FindChildrenRecursive<Item> (v => (v.Parent as Folder)?.Name == name);
var items = build.FindChildrenRecursive<Item> (v => {
var parent = v.Parent as NamedNode;
if (parent?.Name != name)
return false;

if (!(parent is Folder || (parent is AddItem && parent.Parent is Folder)))
return false;

parent = parent.Parent as NamedNode;
if (parent?.Name == "OutputItems")
return false;

return true;
});
foreach (var item in items) {
rv.Add (CreateItem (item));
}
Expand All @@ -91,7 +104,10 @@ public MSBuildItem [] GetItems (ProjectPaths project, string name)
var resolvedProjectPath = PathUtils.ResolveSymbolicLinks (project.ProjectCSProjPath);
var outputItems = build.FindChildrenRecursive<Item> (v => {
var parent = v.Parent as NamedNode;
if (parent?.Name != name || !(parent is Parameter))
if (parent?.Name != name)
return false;

if (!(parent is Parameter || parent is AddItem))
return false;

parent = parent.Parent as NamedNode;
Expand Down

0 comments on commit 5383e31

Please sign in to comment.