Enables FastTreeBinaryClassificationCategoricalSplitTest and BinaryClassifierTesterThresholdingTest #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anipik
changed the title
TomFinley
reviewed
May 29, 2018
| @@ -204,8 +204,8 @@ public static class TestDatasets | |||
| public static TestDataset adult = new TestDataset | |||
| { | |||
| name = "Census", | |||
| trainFilename = @"..\UCI\adult.train", | |||
| testFilename = @"..\UCI\adult.test", | |||
| trainFilename = @"adult.train", | |||
There was a problem hiding this comment.
@ [](start = 28, length = 1)
Thanks for moving the file! This is an improvement.
Now that we no longer have a path hard coded we can remove the @.
There was a problem hiding this comment.
|
@dotnet-bot test OSX10.13 Debug |
|
@dotnet-bot test OSX10.13 Release |
|
@TomFinley I moved the files in both the PRs |
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
…assifierTesterThresholdingTest (dotnet#255) * Tests Enabled & Dataset Moved to correct place in test\BaselineOutput * Correcting path for adult data set for autoInference class, and removing @ from path
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Being Enabled - BinaryClassifierTesterThresholdingTest, FastTreeBinaryClassificationCategoricalSplitTest
Zbaselines used by BinaryClassifierTesterThresholdingTest are already present. The slight difference in numbers is due to change in underlying framework
FastTreeBinaryClassificationCategoricalSplitTest
Learners Used :- FastTreeClassfier, FastTreeWithCategoricalClassfier, FastTreeClassfierDisk, FastTreeWithCategoricalClassfierDisk
Datasets Used:- adultOnlyCat, adult
Files BreakDown For FastTreeBinaryClassificationCategoricalSplitTest :- 40 release files , 40 debug files
Each Learner needs 10 files (5 For each datasets) The 5 files are *.txt, .out.txt, .rp.txt, *.ini, summary.txt
Note :- Release files are exactly same as Debug files
cc @shauheen @Ivanidzo4ka @eerhardt @danmosemsft @codemzs