Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentiment_data.tsv and sentiment_test.tsv are missing in the solution. #475

Closed
joshua-light opened this issue Jul 2, 2018 · 3 comments
Closed

Comments

@joshua-light
Copy link
Contributor

Issue

  • What did you do?
    Opened the solution.

  • What happened?
    I've found that test\data solution folder contains missing files: sentiment_data.tsv and sentiment_test.tsv.
    As it looks in Microsoft.ML.sln it has:

// Starts at 37.
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "data", "data", "{FDA2FD2C-A708-43AC-A941-4D941B0853BF}"
	ProjectSection(SolutionItems) = preProject
	>>	test\data\sentiment_data.tsv = test\data\sentiment_data.tsv
	>>	test\data\sentiment_test.tsv = test\data\sentiment_test.tsv
	EndProjectSection
EndProject

While such data actually doesn't present in repository, as it looks here.

  • What did you expect?
    I'd expect that there should be no missing files in solution.
@joshua-light
Copy link
Contributor Author

I've done something like #14cb62 because by #362 it seems like there was already a wave of non-source files removal.

Still not 100% (not even 80%) sure that I'm not wrong: maybe such data files for test should be in solution or maybe I just forgot to run some scripts (even if I tried to find sentiment_test.csv text-entries in whole repository and there were just one or two).

@TomFinley
Copy link
Contributor

TomFinley commented Jul 3, 2018

As in #362 my own preference would be to have files like this that don't have some immediate bearing on the project's building be omitted from the solution, since they're very hard to track. Certainly it is clear that no one has found the presence of these helpful (how could they?), nor found the absence of all other test files harmful. So what you have in your fork looks good, were you thinking of creating a PR @Joshualight ?

@joshua-light
Copy link
Contributor Author

@TomFinley, thanks for feedback. I'll create a PR probably... right now. ))

eerhardt pushed a commit to eerhardt/machinelearning that referenced this issue Jul 27, 2018
* Removed `data` solution-folder from solution files.

Fixes dotnet#475.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants