-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentiment_data.tsv
and sentiment_test.tsv
are missing in the solution.
#475
Comments
I've done something like #14cb62 because by #362 it seems like there was already a wave of non-source files removal. Still not 100% (not even 80%) sure that I'm not wrong: maybe such data files for test should be in solution or maybe I just forgot to run some scripts (even if I tried to find |
As in #362 my own preference would be to have files like this that don't have some immediate bearing on the project's building be omitted from the solution, since they're very hard to track. Certainly it is clear that no one has found the presence of these helpful (how could they?), nor found the absence of all other test files harmful. So what you have in your fork looks good, were you thinking of creating a PR @Joshualight ? |
@TomFinley, thanks for feedback. I'll create a PR probably... right now. )) |
* Removed `data` solution-folder from solution files. Fixes dotnet#475.
Issue
What did you do?
Opened the solution.
What happened?
I've found that
test\data
solution folder contains missing files:sentiment_data.tsv
andsentiment_test.tsv
.As it looks in Microsoft.ML.sln it has:
While such data actually doesn't present in repository, as it looks here.
I'd expect that there should be no missing files in solution.
The text was updated successfully, but these errors were encountered: