Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrubbing Projection transformers #2831

Closed
Ivanidzo4ka opened this issue Mar 4, 2019 · 3 comments
Closed

Scrubbing Projection transformers #2831

Ivanidzo4ka opened this issue Mar 4, 2019 · 3 comments
Assignees
@wschin
Labels
API Issues pertaining the friendly API

Comments

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Mar 4, 2019 •
edited by artidoro
Loading

Sub task of #2827
RFF, LpNorm, GcNorm, PCA, Whiten, Normalize.
Projection catalog is bad name, and we probably should toss around this transforms across other catalogs.
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Mar 4, 2019
@wschin wschin self-assigned this Mar 5, 2019
@wschin
Copy link
Member

wschin commented Mar 6, 2019

They are in projection because they all map feature vectors to a low-rank space. Why do you think this name is bad?

@wschin wschin mentioned this issue Mar 6, 2019
Merged
@Ivanidzo4ka
Copy link
Contributor Author

Well, for example LpNorm and GcNorm doesn't lower rank at all AFAIK.
And if I correctly remember @TomFinley comment: "What is transformer if not projection of data?"
Maybe DimensionalityReduction is a better catalog name than Projection

@wschin
Copy link
Member

wschin commented Mar 7, 2019

Just updated/created some catalogs. We now create Normalization for all normalizer, DimensionReduction for PCA and VectorWhiten, Kernel for RFF kernel approximation.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wschin wschin

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ivanidzo4ka @wschin