You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Option should have meaning and proper way it initialize it self.
No short names.
public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
I don't think that public thing make sense to me, I would prefer to get rid of it.
Thanks @Ivanidzo4ka , Please make sure that the transforms that are not going 1.0 are not in the scope of this work for now. We can file other issues outside Project 13 for those.
We need to make sure our transforms are in good shape.
No protected fields/members/method in public classes. Only private protected.
Transformer class is sealed.
Transformer/Estimator should and catalog method names should be sensible (Estimators and their catalog extensions should have matching names #2853 fine if slightly different).
Column options cleaning:
public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
I don't think that public thing make sense to me, I would prefer to get rid of it.
No public value tuples (especially in catalog methods) (Value-tuple stragglers in the public API #2881)
List still in progress.
The text was updated successfully, but these errors were encountered: