Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrubbing transformers (Meta issue) #2827

Closed
Ivanidzo4ka opened this issue Mar 4, 2019 · 1 comment
Closed

Scrubbing transformers (Meta issue) #2827

Ivanidzo4ka opened this issue Mar 4, 2019 · 1 comment
Labels
API Issues pertaining the friendly API
Milestone

Comments

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Mar 4, 2019

We need to make sure our transforms are in good shape.

  1. No protected fields/members/method in public classes. Only private protected.

  2. Transformer class is sealed.

  3. Transformer/Estimator should and catalog method names should be sensible (Estimators and their catalog extensions should have matching names #2853 fine if slightly different).

  4. Column options cleaning:

  • Option should have meaning and proper way it initialize it self.
  • No short names.
  1. public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
    I don't think that public thing make sense to me, I would prefer to get rid of it.

  2. No public value tuples (especially in catalog methods) (Value-tuple stragglers in the public API #2881)

List still in progress.

@shauheen
Copy link
Contributor

shauheen commented Mar 5, 2019

Thanks @Ivanidzo4ka , Please make sure that the transforms that are not going 1.0 are not in the scope of this work for now. We can file other issues outside Project 13 for those.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

3 participants