[generator] Change protected members in sealed classes to private. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
changed the title
jonpryor
pushed a commit
that referenced
this pull request
Feb 19, 2020
When generating `Mono.Android.dll` for API-29/v10.0, we get ~12 warnings that we are declaring a new `protected` member within a `sealed` class, e.g.: warning CS0628: 'HttpHost.Hostname': new protected member declared in sealed class There are (at least) three plausible ways to address this warning: 1. Use `Metadata` to change the visibility of these members. 2. Update `generator` so that it doesn't emit the members at all. 3. Update `generator` so the visibility of the members is `private`. The problem with (1) is that if the Java type ever changes in the future to be *non*-`final` -- meaning `protected` members would "make sense" -- the members will remain changed, and will continue until some manual review occurs, which is unlikely to happen. (2) is appealing -- no members at all means smaller bindings -- but means that the members cannot be used from additional `partial` class declarations. (3) allows the members to be used from `partial` classes, if desired, while ensuring that if the type changes to become non-`final` in the future, visibility will "automatically" remain `protected`. Update `generator` so that `protected` members within `final` types are instead bound as `private` members, thus avoiding the CS0628.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating API-29
Mono.Android.dllwe get ~12 warnings that we are declaring a newprotectedmember in asealedclass:The C# compiler makes these members
privateanyways, so we can changegeneratorto make themprivateto eliminate the warning without being a breaking change. The value in continuing to bind them asprivateas opposed to removing them is that they could be used by custom code inpartialclasses.