[RFC FS-1109] Additional intrinsics for the NativePtr module #11682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Happypig375 Where is this at w.r.t. completness, and the RFC? |
|
Just missing the RFC, writing now. |
|
@KevinRansom This looks good to me. Do we want "Experimental this is preview" attributes on the additions to FSharp.Core? Thanks |
dsyme
approved these changes
Jul 13, 2021
|
@vzarytovskii Approved subject to @KevinRansom 's opinion on whether we need the "this is in preview" library attributes. |
|
No I think the preview attributes are not necessary. The APIs are not likely to change, they don't support a specific language feature and Dev 17.0 is the target for main anyway. |
|
Cool thank you! So we have our first non-preview F# 5.1 (or F# 6.0 or whatever) feature :) |
|
Thank you @Happypig375 :) |
|
5.1 I think. |
dsyme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC https://github.com/fsharp/fslang-design/blob/main/preview/FS-1109-Additional-intrinsics-for-the-NativePtr-module.md
fsharp/fslang-suggestions#200