-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analyzer reference in AuditReports package #5894
Conversation
src/Generators/Microsoft.Gen.MetadataExtractor/Microsoft.Gen.MetadataExtractor.csproj
Outdated
Show resolved
Hide resolved
Hello , |
Thanks, I think the implementation is fine, just needed to change ProjectReference -> AnalyzerReference. |
|
@IbrahimMNada can you pull my branch and run your tests? Changes are already done in this PR. |
I ran the tests , all seems good, to be 100% sure i can try the package on a sperate fresh project if you'd like |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=951242&view=codecoverage-tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@RussKie @amadeuszl for approvals |
LGTM. Have you confirmed the change is working as before? E.g., you can build version 9.3 locally, pull dotnet/extensions-samples#645, point it at the locally built version, and verify it can be built. |
I Tried to run this Microsoft.Extensions.AuditReports package locally on a custom project, I could not find the .target file .... the analyzers do not fire when i build... is there any documents can help me generate nupkg with the right .target file |
How did you build and pack? What errors did you observe? Here's a doc with building instructions. To pack you should run
|
thanks for pointing out what i was missing , I was able to create a package and run locally on a side project. this branch contains the same changes as the one main...IbrahimMNada:extensions:meta-data-extractor I generated a package from it then used on a side project , which is this one i defined this in order to test them and thankfully it worked However, i noticed that I believe its related to |
@RussKie confirmed Microsoft.Extensions.AuditReports works. Locally packed and updated samples to test. |
Thank you, folks, for jumping in quickly and fixing the issue. Let's monitor the dependency flow now. |
Fix regression due to #5531
It broke the AuditReports extension since it will not be able to resolve the dependency on Microsoft.Gen.MetadataExtractor.
Microsoft Reviewers: Open in CodeFlow