Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK #30954

Closed
wants to merge 1 commit into from
Closed

Update SDK #30954

wants to merge 1 commit into from

Conversation

MackinnonBuck
Copy link
Member

No description provided.

@bricelam
Copy link
Contributor

In .NET 5, these tests also broke when they obsoleted BinarySerializer. (We worked around that using #pragmas in PR #22305) Now its been escalated to a runtime exception.

@bricelam
Copy link
Contributor

I think @ajcvickers comment from three years ago is still valid:

Seems fine to remove them. It will also stop us being noise when people search for code using BinaryFormatter. 🙃

@bricelam bricelam mentioned this pull request Jun 1, 2023
Merged
@bricelam
Copy link
Contributor

bricelam commented Jun 1, 2023

Superseded by #30992

@bricelam bricelam closed this Jun 1, 2023
@AndriySvyryd AndriySvyryd deleted the mbuck/update-sdk branch December 6, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MackinnonBuck @bricelam