Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Re-enable tests for issue#16389 #16892

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Query: Re-enable tests for issue#16389 #16892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/EFCore.Specification.Tests/Query/GroupByQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2979,7 +2979,7 @@ await AssertMax<Order>(
os => os.GroupBy(o => o.CustomerID).Select(g => g.Sum(gg => gg.OrderID)));
}

[ConditionalTheory(Skip = "Issue#16389")]
[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public virtual async Task All_after_GroupBy_aggregate(bool isAsync)
{
Expand All @@ -2989,7 +2989,7 @@ await AssertAll<Order, int>(
predicate: ee => true);
}

[ConditionalTheory(Skip = "Issue#16389")]
[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public virtual async Task All_after_GroupBy_aggregate2(bool isAsync)
{
Expand All @@ -2999,7 +2999,7 @@ await AssertAll<Order, int>(
predicate: ee => ee >= 0);
}

[ConditionalTheory(Skip = "Issue#16389")]
[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public virtual async Task Any_after_GroupBy_aggregate(bool isAsync)
{
Expand Down
22 changes: 13 additions & 9 deletions test/EFCore.SqlServer.FunctionalTests/Query/GroupByQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1989,14 +1989,12 @@ public override async Task All_after_GroupBy_aggregate(bool isAsync)
await base.All_after_GroupBy_aggregate(isAsync);

AssertSql(
@"
CHECK THE SQL
SELECT CASE
@"SELECT CASE
WHEN NOT EXISTS (
SELECT 1
FROM [Orders] AS [o]
WHERE CAST(0 AS bit) = CAST(1 AS bit)
GROUP BY [o].[CustomerID]) THEN CAST(1 AS bit)
GROUP BY [o].[CustomerID]
HAVING CAST(0 AS bit) = CAST(1 AS bit)) THEN CAST(1 AS bit)
ELSE CAST(0 AS bit)
END");
}
Expand All @@ -2005,17 +2003,23 @@ public override async Task All_after_GroupBy_aggregate2(bool isAsync)
{
await base.All_after_GroupBy_aggregate2(isAsync);

AssertSql(@" ");
AssertSql(
@"SELECT CASE
WHEN NOT EXISTS (
SELECT 1
FROM [Orders] AS [o]
GROUP BY [o].[CustomerID]
HAVING SUM([o].[OrderID]) < 0) THEN CAST(1 AS bit)
ELSE CAST(0 AS bit)
END");
}

public override async Task Any_after_GroupBy_aggregate(bool isAsync)
{
await base.Any_after_GroupBy_aggregate(isAsync);

AssertSql(
@"
CHECK THE SQL
SELECT CASE
@"SELECT CASE
WHEN EXISTS (
SELECT 1
FROM [Orders] AS [o]
Expand Down