Query: Translate GroupBy new {} to GroupBy constant 1 #11911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
May 4, 2018
|
Approved for merge into release/2.1 |
maumar
approved these changes
May 4, 2018
Resolves #11905 Issue: GroupBy(g => new {}) converts to GroupBy(Constant) because of key not being correlated with range variable. We translate GroupBy constant to server but in this case, the constant is of anon type which cannot be put in SQL tree hence translation pipeline failed. Fix is to inject `1` as constant whenever we see GroupBy constant of a type which cannot be represented in SQL. We also don't save it in mapping so that if key is projected out, we construct it again on client side.
|
@dotnet-bot test windows release x64 build |
1 similar comment
|
@dotnet-bot test windows release x64 build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11905
Issue: GroupBy(g => new {}) converts to GroupBy(Constant) because of key not being correlated with range variable.
We translate GroupBy constant to server but in this case, the constant is of anon type which cannot be put in SQL tree hence translation pipeline failed.
Fix is to inject
1as constant whenever we see GroupBy constant of a type which cannot be represented in SQL