-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager loaded navigations should apply Include during expansion phase #16619
Comments
You need to apply include after you know the final projection, otherwise we will sometimes apply unnecessary ones. We have logic that clears includes from NavigationTree for some operations (e.g. All/Any) - perhaps it’s missing for count? |
Apply here is in the sense of populating the tree. Which is happening in reduce phase so even though count removes the includes, reduce phase adds them back. The Include tree should be populated before reduce phase and generation of IncludeExpression should happen during reduce. |
Resolves #16619 This avoids issue of adding includes when includes are not part of projection. Fixed in new nav rewrite
Resolves #16619 This avoids issue of adding includes when includes are not part of projection. Fixed in new nav rewrite
Resolves #16619 This avoids issue of adding includes when includes are not part of projection. Fixed in new nav rewrite
This happens in reduce phase. If we apply Count at the end then we don't need includes but projection still has them causing Count to fail since we are in client eval phase.
The text was updated successfully, but these errors were encountered: