Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationExpansions remove projection after GroupBy #16389

Closed
smitpatel opened this issue Jul 2, 2019 · 1 comment · Fixed by #16892
Closed

NavigationExpansions remove projection after GroupBy #16389

smitpatel opened this issue Jul 2, 2019 · 1 comment · Fixed by #16892
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@smitpatel
Copy link
Contributor

os => os.GroupBy(o => o.CustomerID).Select(g => g.Sum(gg => gg.OrderID)).All(ee => true);

Tree before nav rewrite

bool All(
|__ source: IQueryable<int> Select(
|   |__ source: IQueryable<IGrouping<string, Order>> GroupBy(
|   |   |__ source: DbSet<Order>, 
|   |   |__ keySelector: (Order o) => o.CustomerID), 
|   |__ selector: (IGrouping<string, Order> g) => int Sum(
|       |__ source: g, 
|       |__ selector: (Order gg) => gg.OrderID)), 
|__ predicate: (int ee) => True)

Tree after nav rewrite

bool All(
|__ source: IQueryable<IGrouping<string, Order>> GroupBy(
|   |__ source: DbSet<Order>, 
|   |__ keySelector: (Order o) => o.CustomerID), 
|__ predicate: (IGrouping<string, Order> Param_0) => True)
@smitpatel
Copy link
Contributor Author

Same behavior for Any

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 8, 2019
@ajcvickers ajcvickers assigned smitpatel and unassigned roji Jul 23, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 1, 2019
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16389

Fixed in new nav expansion
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16389

Fixed in new nav expansion
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16389

Fixed in new nav expansion
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants