-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: query filters should be properly composed on top of FromSql #16326
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
smitpatel
added a commit
that referenced
this issue
Aug 7, 2019
This makes look up for EntityQueryable in query tree bit more complex but it adds support for providers to add custom EntityQueryable to carry more metadata as needs to and allow rest of the pipeline to be transparent about it. Current FromSql has be to converted during compilation phase since, we want to parameterize the arguments array in the methodCall. If there is nothing to parameterize then providers can directly create custom Queryable. Resolves #16326
smitpatel
added a commit
that referenced
this issue
Aug 7, 2019
This makes look up for EntityQueryable in query tree bit more complex but it adds support for providers to add custom EntityQueryable to carry more metadata as needs to and allow rest of the pipeline to be transparent about it. Current FromSql has be to converted during compilation phase since, we want to parameterize the arguments array in the methodCall. If there is nothing to parameterize then providers can directly create custom Queryable. Resolves #16326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Currently query filters are applied directly after EntityQueryable, i.e. before FromSQL call - this is unexpected, as FromSQL should be composed directly on top of EntityQueryable.
Instead, nav rewrite should detect that EntityQueryable is part of FromSQL and apply the filter after the FromSQL call
The text was updated successfully, but these errors were encountered: