Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"collection selector was not NavigationExpansionExpression" when joining two FromSql()s #15763

Closed
roji opened this issue May 20, 2019 · 1 comment
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@roji
Copy link
Member

roji commented May 20, 2019

Test FromSqlRaw_queryable_multiple_composed fails with the error "collection selector was not NavigationExpansionExpression" (check after #15752 is merged).

@maumar maumar self-assigned this May 20, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 28, 2019
maumar added a commit that referenced this issue Jun 5, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
maumar added a commit that referenced this issue Jun 7, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
Fix is to add generic handling of simple queryable methods.
maumar added a commit that referenced this issue Jun 7, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
Fix is to add generic handling of simple queryable methods.
maumar added a commit that referenced this issue Jun 7, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
Fix is to add generic handling of simple queryable methods.
maumar added a commit that referenced this issue Jun 8, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
Fix is to add generic handling of simple queryable methods.
maumar added a commit that referenced this issue Jun 8, 2019
…ssion" when joining two FromSql()s

Problem was that navigation expansion wasn't recognizing FromSqlOnQueryable as something that needs to be visited, so the expression was not being converted to NavigationExpansionExpression.
SelectMany requires collection navigation to be a NavigationExpansionExpression, hence the error.
Fix is to add generic handling of simple queryable methods.
@maumar
Copy link
Contributor

maumar commented Jun 8, 2019

fixed in 7bb6d10

@maumar maumar closed this as completed Jun 8, 2019
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 8, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants