Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to empty namespace docs #5055

Merged
merged 6 commits into from
Nov 7, 2020
Merged

Conversation

stefanrbk
Copy link
Contributor

Summary

Added summaries to the following:
System.Runtime.Intrinsics
System.Runtime.Intrinsics.X86
System.Runtime.Intrinsics.Arm

@dnfadmin
Copy link

dnfadmin commented Oct 29, 2020

CLA assistant check
All CLA requirements met.

@opbld33
Copy link

opbld33 commented Oct 29, 2020

Docs Build status updates of commit 0dee100:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.Intrinsics.Arm.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.X86.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -1,6 +1,6 @@
<Namespace Name="System.Runtime.Intrinsics.Arm">
<Docs>
<summary>To be added.</summary>
<summary>Contains classes representing the different SIMD instruction sets available to the ARM architecture. Not all of these instructions sets are available on all ARM CPUs though. Check the "IsSupported" property on each class to determine compatibility with the executing CPU.</summary>
Copy link
Member

@tannergooding tannergooding Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and the same for x86, could likely be reworded slightly. The underlying APIs largely touch SIMD code, but there are also other APIs which aren't SIMD at all.

Perhaps this could say something like:

Exposes select instructions available on ARM (branding needed?) hardware. These instructions are divided into separate classes representing the underlying ISAs (Instruction Set Architectures) exposed by the platform. Support for an ISA can be queried via the IsSupported property exposed on the respective type and may be false if the underlying hardware does not support it or if it is not currently supported by the underlying runtime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this feels more like conceptual docs however and it is a bit more wordy than most summaries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I reworded it, mixing your phrasing with mine. The revised phrasing is able to drop the comment about IsSupported if you deem it too wordy still.

@@ -1,6 +1,6 @@
<Namespace Name="System.Runtime.Intrinsics.X86">
<Docs>
<summary>To be added.</summary>
<summary>Contains classes representing the different SIMD instruction sets available to the x86 architecture. Not all of these instructions sets are available on all x86 CPUs though. Check the "IsSupported" property on each class to determine compatibility with the executing CPU.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth clarifying that x86 includes x64 in this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added x64 in my latest commit.

@opbld32
Copy link

opbld32 commented Oct 30, 2020

Docs Build status updates of commit 68024aa:

🕙 Pending: waiting for processors (33 builds ahead of you)

⚠️ Docs Build is busy, currently there are 33 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld31
Copy link

opbld31 commented Oct 30, 2020

Docs Build status updates of commit 68024aa:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.Intrinsics.Arm.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.X86.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld33
Copy link

opbld33 commented Nov 2, 2020

Docs Build status updates of commit aa004fe:

🕙 Pending: waiting for processors (40 builds ahead of you)

⚠️ Docs Build is busy, currently there are 40 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

stefanrbk and others added 2 commits November 2, 2020 17:06
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Nov 2, 2020

Docs Build status updates of commit 472169e:

🕙 Pending: waiting for processors (40 builds ahead of you)

⚠️ Docs Build is busy, currently there are 40 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld33
Copy link

opbld33 commented Nov 2, 2020

Docs Build status updates of commit c07a8da:

🕙 Pending: waiting for processors (40 builds ahead of you)

⚠️ Docs Build is busy, currently there are 40 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld34
Copy link

opbld34 commented Nov 2, 2020

Docs Build status updates of commit aa004fe:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.Intrinsics.Arm.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.X86.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

gewarren
gewarren previously approved these changes Nov 6, 2020
@gewarren gewarren dismissed their stale review November 6, 2020 22:43

Formatting is off.

@opbld30
Copy link

opbld30 commented Nov 6, 2020

Docs Build status updates of commit 9ac291c:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.Intrinsics.Arm.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.X86.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good now.

@opbld34
Copy link

opbld34 commented Nov 6, 2020

Docs Build status updates of commit 9ac291c:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.Intrinsics.Arm.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.X86.xml ✅Succeeded View
xml/ns-System.Runtime.Intrinsics.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants