BuildGrammar v2.2.0 #1281
Merged
BuildGrammar v2.2.0 #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Add new MS Rules to provide actions & predicates for a number of C#’s
non-grammar rules:
- adjacency requirement for tokens in >> & >>=
- restrict places declaration expressions can be used – as the
grammar for them is very loose
- type argument list disambiguation
- report semantic error if null-forgiving is applied to null-forgiving
- tweak order of choices in a couple of rules so Antlr picks the right one
• Samples:
- Reorganise
- Spilt the large AllInOneNoPreproccesor-v6 into parts
- Add new samples for new constructs
- Switch them all to use the new Rules MS
BillWagner
approved these changes
Mar 3, 2025
|
@BillWagner – Thanks Bill. Nothing should obviously run differently, unless we break the grammar moving forward – and it now tests for more things, including for the first time things that are expected not to parse. Developing it did uncover some issues in the Standard and it will form the basis for tests for a few upcoming issues/PRs to fix those – I'm currently working on §6.2.5 Grammar Ambiguities which is no longer correct… |
|
I would still like @jskeet to take a look, just so he's familiar with this, but I'll merge today to keep our ANTLR testing moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Add new MS Rules to provide actions & predicates for a number of C#’s
non-grammar rules:
- adjacency requirement for tokens in >> & >>=
- restrict places declaration expressions can be used – as the grammar for them is very loose
- type argument list disambiguation
- report semantic error if null-forgiving is applied to null-forgiving
- tweak order of choices in a couple of rules so Antlr picks the right one • Samples:
Note: versioning plan for BuildGrammar vX.Y.Z, increment when:
X – the BuildGrammar tool or other tools change
Y – new modification sets added
Z – samples added
So this is version 2.2.0 as a new MS Rules was added along with new samples