Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[master] Update dependencies from 4 repositories #41197

Closed

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 19, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190918.2
  • Date Produced: 9/18/2019 8:56 PM
  • Commit: a28ee518026d2c5d477472f44d391cf9379fc7cb
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.1-beta.19468.2
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.19468.2
    • Microsoft.DotNet.VersionTools.Tasks -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.ApiCompat -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.Build.Tasks.Configuration -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.Build.Tasks.Feed -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.Build.Tasks.Packaging -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.CodeAnalysis -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.CoreFxTesting -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.GenAPI -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.19468.2
    • Microsoft.DotNet.RemoteExecutor -> 5.0.0-beta.19468.2

From https://github.com/dotnet/core-setup

  • Build: 20190918.6
  • Date Produced: 9/18/2019 11:51 PM
  • Commit: 30c4a25a9a675d632b6e7180e53a87e6fcacb909
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NETCore.App -> 5.0.0-alpha1.19468.6
    • Microsoft.NETCore.DotNetHost -> 5.0.0-alpha1.19468.6
    • Microsoft.NETCore.DotNetHostPolicy -> 5.0.0-alpha1.19468.6

From https://github.com/dotnet/corefx

  • Build: 20190918.14
  • Date Produced: 9/19/2019 4:54 AM
  • Commit: 19b304f
  • Branch: refs/heads/master
  • Updates:
    • runtime.native.System.IO.Ports -> 5.0.0-alpha1.19468.14
    • Microsoft.NETCore.Platforms -> 5.0.0-alpha1.19468.14

From https://github.com/dotnet/standard

  • Build: 20190918.1
  • Date Produced: 9/18/2019 12:50 PM
  • Commit: 718c2c52e2855fe9001467192c5def98790a19cd
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.2.0-prerelease.19468.1

…918.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19468.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19468.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19468.2
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19468.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19468.2
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19468.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19468.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19468.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19468.2
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19468.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19468.2
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19468.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19468.2
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19468.2
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Linux Build arm64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Windows Build x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0190918.6

- Microsoft.NETCore.App - 5.0.0-alpha1.19468.6
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19468.6
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19468.6
…918.14

- runtime.native.System.IO.Ports - 5.0.0-alpha1.19468.14
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19468.14
…90918.1

- NETStandard.Library - 2.2.0-prerelease.19468.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/arcade [master] Update dependencies from 4 repositories Sep 19, 2019
@safern
Copy link
Member

safern commented Sep 19, 2019

This is trying to update the SDK in global.json which is great, however there are some build failures that seem to be caused by this update:

/__w/1/s/.dotnet/sdk/3.0.100-preview9-014004/Microsoft.CSharp.CurrentVersion.targets(100,9): error MSB3041: Unable to create a manifest resource name for "System/Xml/XmlCharType.bin". Could not find a part of the path '/__w/1/s/src/System.Private.Xml/src/System/Xml/System/Xml/XmlCharType.cs'. [/__w/1/s/src/System.Private.Xml/src/System.Private.Xml.csproj]

@ericstj @ViktorHofer have you guys seen this before?

Anyway I'm closing this PR as it contains an arcade breaking change and subscriptions will be triggered again once that breaking change is reverted in the coming hours.

@safern safern closed this Sep 19, 2019
@safern safern deleted the darc-master-cfeb061e-d4aa-4247-b6b4-613997f6c7e4 branch September 19, 2019 16:22
@ViktorHofer
Copy link
Member

cc @ManickaP who hit the same issues when trying to update the SDK locally.

@rainersigwald @livarcocc who might be able to help with the sdk targets.

@rainersigwald
Copy link
Member

Looks like you're hitting dotnet/msbuild#4695 which is fixed in rc2 builds but not preview9 or rc1. Since you've been successfully building in earlier previews which didn't have the DependentUpon convention, you should be able to set

<EmbeddedResourceUseDependentUponConvention>false</EmbeddedResourceUseDependentUponConvention>

for all projects to get through. That may also help even with an SDK that has the bugfix because I think you might hit dotnet/msbuild#4740.

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 19, 2019

Thanks a lot Rainer. I updated the maestro PR (#41216) to depend on 3.0.100-rc2-014265 and will make use of that property if the other regression shows up as well.

@karelz karelz added this to the 5.0 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants