Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Httpstress: Add checksum validation & support plaintext http #40360

Merged
merged 14 commits into from
Aug 22, 2019
Merged

Httpstress: Add checksum validation & support plaintext http #40360

merged 14 commits into from
Aug 22, 2019

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Aug 15, 2019 •
edited
Loading

  • Adds checksum validation for echo operations.
  • Adds support for plaintext http stress tests.
  • Adds trailing header validation.
  • Add error timestamps to final report.
  • Bound size of request headers.
  • Add WinHttpHandler support.

@eiriktsarpalis eiriktsarpalis added tenet-reliability Reliability/stability related issue (stress, load problems, etc.) area-System.Net.Http labels Aug 15, 2019
@eiriktsarpalis eiriktsarpalis added this to the 5.0 milestone Aug 15, 2019
@eiriktsarpalis eiriktsarpalis requested a review from a team August 15, 2019 19:12
@eiriktsarpalis eiriktsarpalis self-assigned this Aug 15, 2019
bartonjs
bartonjs suggested changes Aug 16, 2019
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the ionide symbolCache is, but we probably don't want to submit it.

You might want to submit a different PR to add it to the .gitignore file.

@eiriktsarpalis
Copy link
Member Author

@bartonjs addressed style issues, will follow up with Crc32.NET replacement.

@eiriktsarpalis
Copy link
Member Author

Removed the dependency to CRC32.NET and replaced with a modified version of corefx CRC.cs

bartonjs
bartonjs reviewed Aug 22, 2019
View reviewed changes
src/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs
}

public int FailureCount => Failures.Values.Sum();
public int FailureCount => Failures.Values.Select(x => x.Count).Sum();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public int FailureCount => Failures.Values.Select(x => x.Count).Sum();
public int FailureCount => Failures.Values.Sum(x => x.Count);

@eiriktsarpalis eiriktsarpalis merged commit a25beee into dotnet:master Aug 22, 2019
@eiriktsarpalis eiriktsarpalis deleted the httpstress-add-checksum-validation branch August 22, 2019 20:55
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@eiriktsarpalis
Httpstress: Add checksum validation & support plaintext http (dotnet/…
2077e87 
…corefx#40360)

Httpstress: Add checksum validation & support plaintext http

Commit migrated from dotnet/corefx@a25beee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidsh davidsh davidsh left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Net.Http tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eiriktsarpalis @davidsh @bartonjs