Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: ProcessStart_UseShellExecute_OnUnix_SuccessWhenProgramInstalled(isFolder: False) #29375

Closed
wtgodbe opened this issue Apr 25, 2019 · 9 comments · Fixed by dotnet/corefx#37294
Assignees
Labels
area-System.Diagnostics.Process disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Apr 25, 2019

The test is failing on Linux with:

Assert.Equal() Failure
↓ (pos 0)
Expected: xdg-open
Actual: sh
↑ (pos 0)

There are a few related failures, such as ProcessStart_OpenFileOnLinux_UsesSpecifiedProgramUsingArgumentList(programToOpenWith: \"vi\"). These appear to have been introduced by dotnet/corefx@8b515ad#diff-c2151a182d9032ef4525c69b3569d024 & dotnet/corefx@4214b09#diff-c2151a182d9032ef4525c69b3569d024. The first change is in release/3.0, so we're seeing the failures in preview5 as well.

CC @stephentoub @tmds

@danmoseley
Copy link
Member

This should be fixed by dotnet/corefx#37144.

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 25, 2019

@danmosemsft that PR actually reintroduced these test failures. The timeline goes:

dotnet/corefx#36913 - caused the intial set of failures (this is the current state in release/3.0)
dotnet/corefx#37113 - reverted the previous change, fixed the test failures
dotnet/corefx#37144 - reintroduced the test failures

@danmoseley
Copy link
Member

Oh... @tmds

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 25, 2019

These are outerloop tests, which is why we missed them in CI. You can see the failures from this PR: dotnet/corefx#37197

@tmds
Copy link
Member

tmds commented Apr 26, 2019

I need to investigate further, but on first sight, these may be things we need to update in the tests:

  • LongProcessNamesAreSupported is failing on Alpine. The test itself may be incompatible with Alpine. busybox figures out what the process should do based on the name, and the test is renaming to something busybox doesn't know.
  • ProcessStart_UseShellExecute_OnUnix_SuccessWhenProgramInstalled is failing on a number of distros but not on all. It may have to do with the way xdg-open works.

@stephentoub
Copy link
Member

I'm disabling this test temporarily, as it's causing all outerloop linux runs to fail.

@stephentoub
Copy link
Member

I'm also disabling ProcessTests.LongProcessNamesAreSupported against this issue.

@stephentoub
Copy link
Member

And ProcessTests.ProcessStart_OpenFileOnLinux_UsesSpecifiedProgramUsingArgumentList

@tmds
Copy link
Member

tmds commented May 2, 2019

@stephentoub we need some input here: dotnet/corefx#37294 (comment)

wtgodbe referenced this issue in dotnet/corefx May 16, 2019
…#37294)

* Linux: ProcessName: return script name instead of interpreter program

Fixes https://github.com/dotnet/corefx/issues/37198
Regression by #37144

* Add ProcessNameMatchesScriptName test

* ProcessNameMatchesScriptName: don't run on OSX

* LongProcessNamesAreSupported: don't run on Alpine

* Remove ActiveIssue attributes
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 3.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Process disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants