Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Release/2.0.0 - Make EventArgs serializable #15686

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Release/2.0.0 - Make EventArgs serializable #15686

merged 1 commit into from
Jan 5, 2018

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer added this to the 2.0.x milestone Jan 2, 2018
@ViktorHofer ViktorHofer self-assigned this Jan 2, 2018
@ViktorHofer ViktorHofer requested a review from danmoseley January 2, 2018 19:47
@danmoseley
Copy link
Member

It looks like some of these legs have never passed eg arm_cross_debug_windows_nt_prtest https://ci.dot.net/job/dotnet_coreclr/job/release_2.0.0/job/arm_cross_debug_windows_nt_prtest/
I don't understand why it ran.

@dotnet/dnceng some failures are due to insufficient page file?
https://ci.dot.net/job/dotnet_coreclr/job/release_2.0.0/job/x64_release_windows_nt_pri1_prtest/531/testReport/junit/Regressions_coreclr/_0014_avtest_avtest_/_0014_avtest_avtest_cmd/

@maririos
Copy link
Member

maririos commented Jan 2, 2018 •
edited
Loading

@danmosemsft issue https://github.com/dotnet/core-eng/issues/2324 created for FR to take a look

@danmoseley danmoseley mentioned this pull request Jan 3, 2018
Merged
@danmoseley
Copy link
Member

@dotnet-bot test this please

@ViktorHofer
Copy link
Member Author

I wouldn't wait for the arm legs to pass as this change is minor but as it hasn't yet been approved by shiproom we can't merge either.

@ViktorHofer ViktorHofer force-pushed the release/2.0.0-EventArgs branch from 715fc7e to 8b008aa Compare January 3, 2018 23:28
@ViktorHofer ViktorHofer closed this Jan 3, 2018
@ViktorHofer ViktorHofer force-pushed the release/2.0.0-EventArgs branch from 8b008aa to 7621d45 Compare January 3, 2018 23:29
@ViktorHofer ViktorHofer reopened this Jan 3, 2018
@danmoseley
Copy link
Member

I agree to not wait for the ARM legs.

@ViktorHofer ViktorHofer merged commit 4efa38d into dotnet:release/2.0.0 Jan 5, 2018
@ViktorHofer ViktorHofer deleted the release/2.0.0-EventArgs branch January 5, 2018 00:07
@danmoseley danmoseley mentioned this pull request Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Meta-corelib
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @danmoseley @maririos @Petermarcu