This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix issue #13161. #13299
Merged
Fix issue #13161. #13299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was a crash when calling R2R-compiled code from JITted code on Windows/ARM32. The caller had a live value in `r4` that was scribbled over by the callee. This change adds the necessary call to `regSet.rsTrackRegTrash` which ensures that `r4` is saved/restored in the prolog/epilog when it is used for R2R indirect calls.
|
@BruceForstall @CarolEidt @dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Aug 10, 2017
|
@dotnet-bot test Ubuntu x64 Checked Build and Test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was a crash when calling R2R-compiled code from JITted code
on Windows/ARM32. The caller had a live value in
r4that was scribbledover by the callee. This change adds the necessary call to
regSet.rsTrackRegTrashwhich ensures thatr4is saved/restored inthe prolog/epilog when it is used for R2R indirect calls.