JIT/Performance/CodeQuality/BenchmarksGame/regexdna failing in CI frequently

[jkotas]

FAILED   - JIT/Performance/CodeQuality/BenchmarksGame/regexdna/regexdna/regexdna.sh
               BEGIN EXECUTION
               /Users/dotnet-bot/j/workspace/dotnet_coreclr/master/checked_osx10.12_tst_prtest/bin/tests/Windows_NT.x64.Checked/Tests/coreoverlay/corerun regexdna.exe
               Using input file /Users/dotnet-bot/j/workspace/dotnet_coreclr/master/checked_osx10.12_tst_prtest/bin/tests/Windows_NT.x64.Checked/Tests/coreoverlay/../../JIT/Performance/CodeQuality/BenchmarksGame/regexdna/regexdna/regexdna-input25.txt
               agggtaaa|tttaccct 1
               [cgt]gggtaaa|tttaccc[acg] 0
               a[act]ggtaaa|tttacc[agt]t 0
               ag[act]gtaaa|tttac[agt]ct 0
               agg[act]taaa|ttta[agt]cct 0
               aggg[acg]aaa|ttt[cgt]ccct 1
               agggt[cgt]aa|tt[acg]accct 0
               agggta[cgt]a|t[acg]taccct 0
               agggtaa[cgt]|[acg]ttaccct 0
               
               333
               250
               318
               agggtaaa|tttaccct 1
               [cgt]gggtaaa|tttaccc[acg] 0
               a[act]ggtaaa|tttacc[agt]t 0
               ag[act]gtaaa|tttac[agt]ct 0
               agg[act]taaa|ttta[agt]cct 0
               aggg[acg]aaa|ttt[cgt]ccct 1
               agggt[cgt]aa|tt[acg]accct 0
               agggta[cgt]a|t[acg]taccct 0
               agggtaa[cgt]|[acg]ttaccct 0
               
               333
               250
               318
               regexdna [1 iters]: 5ms
               {0x57b035-0x109754f80} ASSERT [CRITSEC] at /Users/dotnet-bot/j/workspace/dotnet_coreclr/master/checked_osx10.12_prtest/src/pal/src/sync/cs.cpp.380: Thread tid=5746741 deleting a CS owned by thread tid=5746853
               ./regexdna.sh: line 243: 42650 Trace/BPT trap: 5       $_DebuggerFullPath "$CORE_ROOT/corerun" $ExePath $CLRTestExecutionArguments
               Expected: 100
               Actual: 133
               END EXECUTION - FAILED

[jkotas]

Failed in dotnet/coreclr#13774, dotnet/coreclr#13753, dotnet/coreclr#13757, dotnet/coreclr#13759

[jkotas]

This is crashing when destructing s_initializeYieldProcessorNormalizedCrst during shutdown. The PAL is half dead at that point and so we are crashing randomly.

The static critical sections need to be CrstStatic. CrstStatic does not have implicit constructors/destructors and so it does not have these sort of problems.

cc @kouvel

[kouvel]

Darn sorry about that, and thanks for figuring it out, I'll fix asap