CommandLineConfiguration.ThrowIfInvalid #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
requested review from
baronfel,
Keboo,
adamsitnik and
vlada-shubina
jonsequitur
force-pushed
the
configuration-validation
branch
from
711342a to
443932d
Compare
Keboo
reviewed
Jan 14, 2022
| public class CommandLineConfigurationException : Exception | ||
| { | ||
| /// <inheritdoc /> | ||
| public CommandLineConfigurationException(string message) : base(message) |
There was a problem hiding this comment.
I believe you will want to define out the other three constructors https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/exceptions/creating-and-throwing-exceptions#defining-exception-classes
There was a problem hiding this comment.
Easy enough. Any suggestions on an existing exception type that might be appropriate rather than defining a custom one?
19 tasks
jonsequitur
force-pushed
the
configuration-validation
branch
from
02dadde to
3f7dec2
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1581.