Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[blazor][wasm] unify startup bit more" #45993

Closed
wants to merge 1 commit into from
Closed

Revert "[blazor][wasm] unify startup bit more" #45993

wants to merge 1 commit into from

Conversation

TanayParikh
Copy link
Contributor

Reverts #45628 as it's causing build issues in the repo:

image

cc/ @pavelsavara

@TanayParikh TanayParikh requested a review from a team as a code owner January 10, 2023 17:15
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 10, 2023
@pavelsavara
Copy link
Member

How did the CI passed on my PR ?

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Jan 10, 2023 •
edited
Loading

How did the CI passed on my PR ?

Looks like the CI passed a ~week back. There may've been changes in main since which could've led to this behavior.

@pavelsavara
Copy link
Member

We will see it soon on main https://dev.azure.com/dnceng-public/public/_build/results?buildId=132213&view=results

@pavelsavara
Copy link
Member

I think that deleting src\Components\Web.JS\node_modules locally may help as there could be stale dotnet.d.ts in there.

@pavelsavara pavelsavara mentioned this pull request Jan 10, 2023
Merged
@TanayParikh
Copy link
Contributor Author

Superseded by #45997

@TanayParikh TanayParikh deleted the revert-45628-wasm_unify_startup1 branch January 10, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanayParikh @pavelsavara