Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump binlogtool to latest #14313

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

KirillOsenkov
Copy link
Member

@KirillOsenkov KirillOsenkov commented Dec 19, 2023

@KirillOsenkov
Copy link
Member Author

MSBuild made a fix that we need to react to.

Original PR:
#14253

Fix in MSBuildStructuredLog repo:
KirillOsenkov/MSBuildStructuredLog@83a97d0

@JanKrivanek
Copy link
Member

JanKrivanek commented Dec 20, 2023

I believe binlogtool package is already setup to autoupdate in dnceng feed. But just for sure I run the pipeline to explixitly update it to latest (1.0.9 now) https://dev.azure.com/dnceng/internal/_build/results?buildId=2339039&view=results

@ViktorHofer ViktorHofer merged commit 059c502 into dotnet:main Dec 20, 2023
@KirillOsenkov KirillOsenkov deleted the dev/kirillo/bumpBinlogtool branch December 20, 2023 17:26
@JanKrivanek
Copy link
Member

I believe binlogtool package is already setup to autoupdate in dnceng feed. But just for sure I run the pipeline to explixitly update it to latest (1.0.9 now) https://dev.azure.com/dnceng/internal/_build/results?buildId=2339039&view=results

So the pipeline run succeeded giving me a false sense of everything is ok, but the update actually didn't happen:

Getting all versions for package 'binlogtool'
Found 2 versions in 'dotnet-public'
Skipping 'binlogtool' as owner (kirillosenkov) is unknown or not in allowed list.

So it lead to couple issues in promotion pipeline :-/

Reruning the feed push pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=2339968&view=results

@JanKrivanek
Copy link
Member

Redaction is again running fine in the promotion pipeline :-)
The failed upload turned out to be a wrong parameter ('update' instead of 'new or non-microsoft')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropertyReassignment Resource string null Binlog redaction was failing and was disabled
3 participants