[nativeaot] default to $(PublishAotUsingRuntimePack)=true
#9815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/xamarin/xamarin-macios/blob/d4baff4c6847a413e6a9c60089edfff50611ea9b/dotnet/targets/Xamarin.Shared.Sdk.props#L192 `$(PublishAotUsingRuntimePack)` needs to be `true` for any NativeAOT scenario on mobile. This setting is more useful for desktop platforms, as you aren't cross-compiling anything. Desktop builds can potentially use the packs from the .NET SDK as the host and target match. xamarin/xamarin-macios also defaults `$(PublishAotUsingRuntimePack)=true` when `$(PublishAot)=true`, so we should be safe to follow suit.
jonathanpeppers
requested review from
dellis1972 and
jonpryor
as code owners
dellis1972
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-macios/blob/d4baff4c6847a413e6a9c60089edfff50611ea9b/dotnet/targets/Xamarin.Shared.Sdk.props#L192
$(PublishAotUsingRuntimePack)needs to betruefor any NativeAOT scenario on mobile. This setting is more useful for desktop platforms, as you aren't cross-compiling anything. Desktop builds can potentially use the packs from the .NET SDK as the host and target match.xamarin/xamarin-macios also defaults
$(PublishAotUsingRuntimePack)=truewhen$(PublishAot)=true, so we should be safe to follow suit.