[Mono.Android] Add pathSuffix and pathAdvancedPattern to [IntentFilter]

[jpobst]

Fixes: #8235

Adds the following properties to [IntentFilter] to allow the specified AndroidManifest.xml attributes to be generated:

• DataPathSuffix -> pathSuffix
• DataPathSuffixes -> pathSuffix
• DataPathAdvancedPattern -> pathAdvancedPattern
• DataPathAdvancedPatterns -> pathAdvancedPattern

Note that while we have a script to detect new elements added to AndroidManifest.xml, the code must be written manually. Filed #8272 because we really should automate this code generation.

[jonathanpeppers]

There is a block above like:

#if ANDROID_25
		public string?    RoundIcon       {get; set;}
#endif

Is it possible RoundIcon doesn't actually work? Do we need to define all of them?

[jpobst]

There are tests for it, so I assume it works:
https://github.com/xamarin/xamarin-android/blob/789773ec9989e665000ee47793a3910b82891f5f/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs#L936

I think it uses some sort of alternative method, as the value is processed in a local variable since the property isn't available:
https://github.com/xamarin/xamarin-android/blob/789773ec9989e665000ee47793a3910b82891f5f/src/Xamarin.Android.Build.Tasks/Mono.Android/IntentFilterAttribute.Partial.cs#L16

[jonpryor]

This doesn't "feel" right to me, in that we're adding both DataPathSuffix and DataPathSuffixes, but this code only deals with DataPathSuffixes, not DataPathSuffix. Ditto the following line, which appears to deal only with DataPathAdvancedPatterns, and not DataPathAdvancedPattern.

[jpobst]

This class felt like maybe the code was trying to be too "clever", hindering readability. It would likely get rewritten to something a little more straightforward if/when we do this: #8272.

[jonpryor]

I think this test is providing a false sense of security, as the "singular" DataPathSuffix + DataPathAdvancedPattern attribute uses the same values as the "plural" DataPathSuffixes and DataPathAdvancedPatterns form on the following line.

These should use different values, so that we can more easily verify that both are working.

That said, based on the current expected, I think my previous feeling is wrong, because the test method uses .First(), which will be the "singular' data, and that's working. Yay! (But I don't understand how or why it's working…)

Please update this and the following line so that unique values are used, a'la:

[IntentFilter (new [] { "singularAction" },
    DataPathSuffix = "singularSuffix",
    DataPathAdvancedPattern = "singularPattern")]
[IntentFilter (new [] { "pluralAction" },
    DataPathSuffixes = new [] { "pluralSuffix1", "pluralSuffix2" },
    DataPathAdvancedPatterns = new [] { "pluralPattern1", "pluralPattern2" })]

[jpobst]

Good call, tests are much clearer now.

[jonpryor]

draft commit message:

Fixes: https://github.com/xamarin/xamarin-android/issues/8235

Context: https://github.com/xamarin/xamarin-android/issues/8272

Add the following properties to `IntentFilterAttribute` to allow
the various `AndroidManifest.xml` [`<data/>`][0] attributes to
be generated:

  - `IntentFilterAttribute.DataPathSuffix` generates
    [`//intent-filter/data/@pathSuffix`][1].
  - `IntentFilterAttribute.DataPathSuffixes` generates
    [`//intent-filter/data/@pathSuffix`][1].
  - `IntentFilterAttribute.DataPathAdvancedPattern` generates
    [`//intent-filter/data/@pathAdvancedPattern`][1].
  - `IntentFilterAttribute.DataPathAdvancedPatterns` generates
    [`//intent-filter/data/@pathAdvancedPattern`][1].

Note that while we have a script to detect new elements added to
`AndroidManifest.xml`, the code must be written manually.

TODO: Issue #8272 to automate this code generation.

[0]: https://developer.android.com/guide/topics/manifest/data-element
[1]: https://developer.android.com/guide/topics/manifest/data-element#path