Test JI delegate cache change. #7478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Oct 24, 2022
) Context: 1720628 Context: dotnet/android#7478 Context: https://github.com/buyaa-n/runtime/blob/7a62a22db186fda42dad6cbd681cf056fcf6aee6/src/libraries/System.Private.CoreLib/src/System/Runtime/Versioning/PlatformAttributes.cs#L52-L62 In order to compile classic MonoAndroid bindings that contain the new .NET `[SupportedOSPlatform]` attributes, we have a dummy copy that we can compile against. However this copy does not allow `AttributeTargets.Field`, so compiling with 1720628 causes: /Users/builder/azdo/_work/1/s/xamarin-android/src/Mono.Android/obj/Release/monoandroid10/android-33/mcw/Dalvik.Bytecode.IOpcodes.cs(646,4): error CS0592: Attribute global::System.Runtime.Versioning.SupportedOSPlatformAttribute' is not valid on this declaration type. It is only valid on 'assembly, module, class, struct, constructor, method, property, indexer, event' declarations. Update our copy to have the same `AttributeTargets` as the .NET version so we can compile on classic.
jpobst
force-pushed
the
ji-delegate-cache
branch
from
171c385 to
d147d6a
Compare
|
Superseded by PR #7502. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.