Nullability for AndroidMessageHandler.RequestNeedsAuthorization #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation The annotation allows RequestedAuthentication to be used without a null-check after testing RequestNeedsAuthorization, when nullability analysis is enabled.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
approved these changes
Oct 11, 2022
jonathanpeppers
requested changes
Oct 11, 2022
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for your contribution! |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 17, 2022
* main: [Mono.Android] nullability for AndroidMessageHandler.RequestNeedsAuthorization (dotnet#7454) [Xamarin.Android.Build.Tasks] Fix up `ToJniName` to use `cache`. (dotnet#7460) Bump to xamarin/android-api-docs@52d85154 (dotnet#7459) Bump to xamarin/xamarin-android-tools/main@9f56dec (dotnet#7456)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 18, 2022
* main: [Mono.Android] nullability for AndroidMessageHandler.RequestNeedsAuthorization (dotnet#7454) [Xamarin.Android.Build.Tasks] Fix up `ToJniName` to use `cache`. (dotnet#7460) Bump to xamarin/android-api-docs@52d85154 (dotnet#7459) Bump to xamarin/xamarin-android-tools/main@9f56dec (dotnet#7456)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My project uses AndroidMessageHandler. Currently, idiomatic code like this produces a nullability warning:
This PR adds a MemberNotNullWhen attribute that allows RequestedAuthentication to be used without a null-check after testing RequestNeedsAuthorization.