[One .NET] exclude libxamarin-debug-app-helper.so from Release builds #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#5855 Currently, in .NET 6, any `.so` file in our runtime pack is included in apps by default. This is the nature of how native libraries coming from NuGet packages work. They just get added based on the file path and `$(RuntimeIdentifier)` of the project. We already have a special case for `libmono-android.release.so` and `libmono-android.debug.so` that uses `$(AndroidIncludeDebugSymbols)` as a way to know which native library is needed. We can do the same thing here and exclude `libxamarin-debug-app-helper.so`, which should only be included in `Debug` builds. This saves ~37K for all Release apps: -37,104 lib/arm64-v8a/libxamarin-debug-app-helper.so *1
grendello
approved these changes
Apr 26, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The one failure seems unrelated: |
jonathanpeppers
added a commit
that referenced
this pull request
Apr 27, 2021
…#5874) Fixes: #5855 Currently, in .NET 6, any `.so` file in our runtime pack is included in apps by default. This is the nature of how native libraries coming from NuGet packages work. They just get added based on the file path and `$(RuntimeIdentifier)` of the project. We already have a special case for `libmono-android.release.so` and `libmono-android.debug.so` that uses `$(AndroidIncludeDebugSymbols)` as a way to know which native library is needed. We can do the same thing here and exclude `libxamarin-debug-app-helper.so`, which should only be included in `Debug` builds. This saves ~37K for all Release apps: -37,104 lib/arm64-v8a/libxamarin-debug-app-helper.so *1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5855
Currently, in .NET 6, any
.sofile in our runtime pack is includedin apps by default. This is the nature of how native libraries coming
from NuGet packages work. They just get added based on the file path
and
$(RuntimeIdentifier)of the project.We already have a special case for
libmono-android.release.soandlibmono-android.debug.sothat uses$(AndroidIncludeDebugSymbols)as a way to know which native library is needed.
We can do the same thing here and exclude
libxamarin-debug-app-helper.so, which should only be included inDebugbuilds.This saves ~37K for all Release apps: