Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit remaining unported Classic test suites #7906

Closed
jpobst opened this issue Mar 21, 2023 · 4 comments
Closed

Audit remaining unported Classic test suites #7906

jpobst opened this issue Mar 21, 2023 · 4 comments
Labels
Area: Unit Tests Issues with repo unit tests. enhancement Proposed change to current functionality.
Milestone
.NET 9

Comments

@jpobst
Copy link
Contributor

jpobst commented Mar 21, 2023 •
edited
Loading

We are removing "Classic" Xamarin.Android code from the main branch. "Classic" will continue to be maintained for the remainder of its supported lifetime out of existing branch(es). (Currently d17-5)

The following test suites do not currently have .NET equivalents. We need to determine if they should be ported to .NET or if they are no longer relevant and can be removed.

  • Xamarin.Android.JcwGen-Tests.csproj
  • Xamarin.Android.JcwGen-Tests.csproj /p:AndroidFastDeploymentType=Assemblies:Dexes
  • Xamarin.Android.Locale-Tests.csproj
  • Xamarin.Android.Locale-Tests.csproj /p:AotAssemblies=True
  • Xamarin.Android.Locale-Tests.csproj /p:AotAssemblies=True /p:AndroidEnableProfiledAot=true
  • EmbeddedDSO.csproj
  • Xamarin.Forms.Performance.Integration.Droid.csproj
  • Xamarin.Forms.Performance.Integration.Droid.csproj /p:AotAssemblies=true
  • Xamarin.Forms.Performance.Integration.Droid.csproj /p:AotAssemblies=True /p:AndroidEnableProfiledAot=true
  • VSAndroidAppProxy.csproj
  • Xamarin.Android.Bcl-Tests.csproj
@ghost ghost added the needs-triage Issues that need to be assigned. label Mar 21, 2023
@jpobst jpobst added Area: Unit Tests Issues with repo unit tests. and removed needs-triage Issues that need to be assigned. labels Mar 21, 2023
@jpobst jpobst mentioned this issue Mar 21, 2023
Open
@jonpryor
Copy link
Member

@dellis1972: is there a need for tests/locales/Xamarin.Android.Locale-Tests*.csproj? We have existing localization tests which appear to run under .NET 7+, e.g. PR #6693, so are these projects duplciative?

@jonpryor
Copy link
Member

@steveisok: do we want to run the dotnet/runtime BCL tests in a .NET Android environment? Or is that not a huge concern?

If it is a concern, what's the "sanest" way to do that?

@dellis1972
Copy link
Contributor

@dellis1972: is there a need for tests/locales/Xamarin.Android.Locale-Tests*.csproj? We have existing localization tests which appear to run under .NET 7+, e.g. PR #6693, so are these projects duplciative?

Looks like there might be some tests in there we should port to the more comprehensive tests we have in #6693, e.g the Environment tests and the Globalisation checks.

@jpobst jpobst mentioned this issue Mar 28, 2023
Merged
jpobst added a commit that referenced this issue Apr 5, 2023
@jpobst
[ci] Remove remaining Classic test jobs. (#7924)
209c8c6 
Removes the remaining Xamarin.Android Classic test jobs from `main` ci.

Not all of these have been ported to .NET.  Issue #7906 tracks these jobs and whether we should port them or if they are no longer needed.

Additionally, this no longer builds or uploads the Classic `.vsix`/`.pkg` installers.
@jpobst jpobst added this to the .NET 9 milestone Dec 12, 2023
@jpobst jpobst added the enhancement Proposed change to current functionality. label Jan 24, 2024
@jpobst
Copy link
Contributor Author

jpobst commented May 17, 2024

If we aren't running them by now, they must not be important. ;)

Closing.

@jpobst jpobst closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Unit Tests Issues with repo unit tests. enhancement Proposed change to current functionality.
Projects
None yet
Milestone
.NET 9
Development

No branches or pull requests
3 participants
@jonpryor @jpobst @dellis1972