Enable analyzers for single-file like targets #5943
Assignees
Labels
Area: App+Library Build
Issues when building Library projects or Application projects.
Milestone
Comments
jpobst
added
Area: App+Library Build
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this issue
Jun 3, 2021
Fixes: dotnet#5943 Context: https://github.com/dotnet/sdk/blob/c1b8e80be1f7cca767ed9f3c90a45d6830b166a0/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets#L92-L96 By default, we need to enable ILLink's "single file" analyzers for Android app projects. We should also do this for `Mono.Android.csproj` and `Mono.Android.Export.csproj`. After enabling this analyzer, no warnings appeared. But I do see the appropriate analyzers setup in projects now: Analyzer ~\android-toolchain\dotnet\sdk\6.0.100-preview.6.21280.2\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\ILLink.CodeFixProvider.dll IsImplicitlyDefined = true ~\dotnet\sdk\6.0.100-preview.6.21280.2\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\ILLink.RoslynAnalyzer.dll IsImplicitlyDefined = true
jonpryor
pushed a commit
that referenced
this issue
Jun 9, 2021
Fixes: #5943 Context: https://github.com/dotnet/sdk/blob/c1b8e80be1f7cca767ed9f3c90a45d6830b166a0/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets#L92-L96 Context: https://docs.microsoft.com/en-us/dotnet/core/deploying/single-file Context: dotnet/sdk#15239 [.NET Single File Apps][0] are a .NET deployment construct in which "all application-dependent files [are built] into a single binary." It's conceptually similar to Xamarin.Android `.apk` files, and there is some overlap in the "semantic [API incompatibilities][1]" between "normal" desktop .NET apps and Xamarin.Android/single-file apps, such as the (lack of) utility in `Assembly.Location`, which is the empty string in Xamarin.Android apps when `$(EmbedAssembliesIntoApk)`=True, which is required for "app store" distribution. For .NET 6+ app builds, enable analyzers which check for usage of these "semantically changed" APIs, by setting `$(EnableSingleFileAnalyzer)`=True. Update `Mono.Android.csproj` and `Mono.Android.Export.csproj` to also enable the single-file analyzers. After enabling this analyzer, no warnings appeared. But I do see the appropriate analyzers setup in projects now: Analyzer ~\android-toolchain\dotnet\sdk\6.0.100-preview.6.21280.2\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\ILLink.CodeFixProvider.dll IsImplicitlyDefined = true ~\android-toolchain\dotnet\sdk\6.0.100-preview.6.21280.2\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\ILLink.RoslynAnalyzer.dll IsImplicitlyDefined = true [0]: https://docs.microsoft.com/en-us/dotnet/core/deploying/single-file [1]: https://docs.microsoft.com/en-us/dotnet/core/deploying/single-file#api-incompatibility
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
.NET6 comes with a new set of analyzers that will issue warnings and offer code fixes for APIs calls that are not supported for single-file setups.
What is needed on the SDK side is to enable
EnableSingleFileAnalyzermsbuild property. It would be useful to have this enabled for all android targets but also for the SDK build as well.The text was updated successfully, but these errors were encountered: