Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to microsoft/vcpkg@c8696863d3 #133

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Jan 11, 2024

Changes: microsoft/vcpkg@94ce0da...c869686

A recent build attempt failed downloading various mingw dependencies:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8898600&view=logs&j=dcf9cb13-bc72-55bf-54b2-a34a02160417&t=c05507e5-95d2-500e-0fcb-12f725f05b68

Error: Failed to download from mirror set:
https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst: failed: status code 404

Bumping to the latest vcpkg release tag appears to fix this.

Changes: microsoft/vcpkg@94ce0da...c869686

A recent build attempt failed downloading various mingw dependencies:

    Error: Failed to download from mirror set:
    https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst: failed: status code 404

Bumping to the latest vcpkg release tag appears to fix this.
@pjcollins
Copy link
Member Author

@grendello @dellis1972 I'm not sure if this is the best way to fix the issue I hit trying to build recently, and am not entirely sure how many vcpkg dependency versions may be changing as a result of this change. Do either of you have any thoughts on how best to resolve the recent build break?

@grendello
Copy link
Contributor

In the long run, it might make sense to switch away from vcpkg to https://cmake.org/cmake/help/latest/module/FetchContent.html#module:FetchContent, but if the bump fixes the issue now, then I'm all for it.

@pjcollins pjcollins merged commit 22957e4 into main Jan 12, 2024
@pjcollins pjcollins deleted the dev/pjc/vcpkg-2023-12-12 branch January 12, 2024 18:33
jonpryor pushed a commit to dotnet/android that referenced this pull request Feb 15, 2024
jonathanpeppers pushed a commit to dotnet/android that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants