Merge to shared - TdsParserStaticMethods #1603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraith2
reviewed
May 4, 2022
| // For ProjectK\CoreCLR we don't want to take a dependency on the registry to try to read a value | ||
| // that isn't usually set, so we'll just use a random value each time instead | ||
| if (null == s_nicAddress) | ||
| { | ||
| byte[] newNicAddress = new byte[TdsEnums.MAX_NIC_SIZE]; | ||
| Random random = new Random(); | ||
| Random random = new(); |
There was a problem hiding this comment.
We should dispose the Random instance, there was a PR recently to make sure that was done elsewhere in this library.
The Type name = new() is less clear than var name = new Type() imo and I thought we had added an editorconfig entry to prevent auto suggestion of the first version in the main library projects.
|
I'm not a big fan of using #ifdef's in the main files. I've not checked if there's a better way to do this but if there is it'd be better to have .netfx.cs and .netcore.cs files with parts of the partial class in them. |
|
Closing this PR since #1588 addresses the same merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261. Merged netfx into netcore for TdsParserStaticMethods, and moving it to shared src and updating file to conform with coding style.