Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for parameter updates and code modifier configs for web apps / … #1905

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

zahalzel
Copy link
Contributor

@zahalzel zahalzel commented May 24, 2022

Updates for "Do not use top-level statements" for adding code when the identity templates are not selected in VS

Fixes for parameter updates and code modifier configs for web apps / web apis that use startup.cs, specifically .Net5 projects

@zahalzel zahalzel requested a review from deepchoudhery May 25, 2022 23:58
Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zahalzel zahalzel merged commit 1a262d7 into main Jun 2, 2022
deepchoudhery pushed a commit that referenced this pull request Jun 2, 2022
#1905)

* Fixes for parameter updates and code modifier configs for web apps / web apis that use startup.cs

* Refactor top-level statement code modification

* Fix formatting

* Remove debugger
deepchoudhery added a commit that referenced this pull request Jun 2, 2022
* Fix spacing and change for minimal api scopes (#1901)

* adding IdentityHostingStartup file back (#1907)

* supporting os version tfm for "-windows" (#1909)

* Fixes for parameter updates and code modifier configs for web apps / … (#1905)

* Fixes for parameter updates and code modifier configs for web apps / web apis that use startup.cs

* Refactor top-level statement code modification

* Fix formatting

* Remove debugger

* Refactor appsettings.json modification logic (#1903)

* refactor appSettings

* Refactoring appsettings modifier

* refactor appSettings and ServerAPI block

* Refactor appsettings and tests

* PR comments

* bumping msidentity and aspnet-codegenerator v

Co-authored-by: Zachary Halzel <zahalzel@microsoft.com>
@zahalzel zahalzel deleted the dev/zahalzel/fix_startup_code_modifier branch June 13, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants