Propagate correct tenant ID from command line args #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayrkn
approved these changes
Aug 6, 2021
|
@zahalzel - Lets bump the version to preview 4 in a follow up PR. https://github.com/dotnet/Scaffolding/blob/main/eng/Versions.MSIdentity.props#L11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the CLI tool from VS, the tenant ID parameter sent in was not being used for creating app registrations, updating app registrations, etc. So in certain cases the CLI tool will infer the wrong tenant ID from the VS project rather than using the tenant that the VS user has currently selected. This change makes it so the CLI tool uses the tenant ID parameter sent in from VS for these operations.