-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--update-project feature work #1593
Conversation
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeWriter.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
test/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity.UnitTests.Tests/ProjectModifierTests.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectExtensions.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectWorkspace.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectWorkspace.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectExtensions.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Carrying over comments from https://github.com/dotnet/Scaffolding/pull/1582/files/7435445dfe7c11b8e1f872a83dd1777b0a1f7dae
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeAnaylsisHelper.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeAnaylsisHelper.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/DocumentBuilder.cs
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/DocumentBuilder.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/AppProvisioningTool.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeAnaylsisHelper.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeAnaylsisHelper.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeModifierConfig.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeModifierConfig.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review carried over from #1582
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* update-project with code changes * minor fix * more updates * minor fixes * minor fixes * fixed Resources and other minor fixes
77b76d8
to
b097222
Compare
Draft PR for now.
Will have more incoming changes and tests throughout the review.
Code changes are done through json configs. Only C# files are edited.
Each project type/scenario should have a json config file for itself.
This info is also available in CodeModifierConfig folder as well.
The scenarios below need to be supported for all project types :