Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored Scaffolding and added MsIdentityScaffolding #1528

Merged
merged 6 commits into from
Mar 19, 2021
Merged

refactored Scaffolding and added MsIdentityScaffolding #1528

merged 6 commits into from
Mar 19, 2021

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Mar 17, 2021 •
edited
Loading

  • On commit from dotnet/MsIdentity.
  • added .github for filing different issues, questions, and feature requests.
  • changed Scaffolding.sln --> All.sln.
    - dotnet-aspnet-codegenerator, and the dotnet-scaffolding projects can be loaded with Scaffolding.slnf
    - dotnet-msidentity can be loaded using MsIdentity.slnf
  • added scripts/ folder to build and install dotnet-scaffolding, dotnet-aspnet-codegenerator, and dotnet-msidentity separetely.
  • new folder structure
    image

@deepchoudhery deepchoudhery requested a review from vijayrkn March 17, 2021 21:41
@deepchoudhery deepchoudhery self-assigned this Mar 17, 2021
@deepchoudhery deepchoudhery marked this pull request as draft March 17, 2021 21:41
@deepchoudhery deepchoudhery marked this pull request as ready for review March 17, 2021 22:32
vijayrkn
vijayrkn requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@vijayrkn vijayrkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no other code changes, approving.

@deepchoudhery deepchoudhery requested a review from vijayrkn March 19, 2021 00:51
@deepchoudhery deepchoudhery merged commit 1cda93c into main Mar 19, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/refactorAndAddMsIdentity branch March 19, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayrkn vijayrkn vijayrkn approved these changes

@sayedihashimi sayedihashimi Awaiting requested review from sayedihashimi

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepchoudhery @vijayrkn