Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide columns for multiple runtime #1621

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

marcnet80
Copy link
Contributor

@YegorStepanov
Copy link
Contributor

Just for info:

Currently, all BDN columns have IsAvailable=true.

It means Job and Toolchain always be in *-report.csv. The PR deletes this columns, when Runtime is different.

The user-friendly exporters show columns when SummaryTableColumn.NeedToShow == true. The log-friendly ignore this property.

I don't know what behavior is acceptable.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcnet80 I am terribly sorry for the delay in the review process. Since I really want to include this change in 0.13.2, I've pushed some minor improvements directly to your fork. I hope you don't mind.

Thank you again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants