Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Iced #1502

Merged
merged 4 commits into from
Jul 18, 2020
Merged

Update to latest Iced #1502

merged 4 commits into from
Jul 18, 2020

Conversation

Symbai
Copy link
Contributor

@Symbai Symbai commented Jul 17, 2020

Iced released a 1.8.0 some hours ago, see https://github.com/0xd4d/iced/releases/tag/v1.8.0 for changes.

@adamsitnik
Copy link
Member

@Symbai could you please update it in the BenchmarkDotNet.csproj as well?

<PackageReference Include="Iced" Version="1.4.0" />

@Symbai
Copy link
Contributor Author

Symbai commented Jul 17, 2020

Weird, how did that went through? Compiled and run tests and all seems fine. I simply didn't noticed there was another reference. Thank you, updated the pull request.

@Symbai
Copy link
Contributor Author

Symbai commented Jul 17, 2020

Fixed build, you can now review it again.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Symbai thanks!

@adamsitnik adamsitnik merged commit b356ac8 into dotnet:master Jul 18, 2020
@AndreyAkinshin AndreyAkinshin added this to the v0.12.2 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants