Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Runtime Pack option #1501

Merged
merged 12 commits into from
Jul 17, 2020

Conversation

naricc
Copy link

@naricc naricc commented Jul 16, 2020

This adds an option to specify a custom runtime pack (currently only used by wasm, but in principle useful for other net5.0 appolications). This is used to run against a custom built net5.0 runtime.

@naricc
Copy link
Author

naricc commented Jul 17, 2020

@adamsitnik (I can't actually add reviewers)

@SamMonoRT
Copy link
Member

@adamsitnik - is it possible to kick off a re-run of the BenchmarkDotNet - macOS lane to confirm it is not related to changes here. Also, if you have a moment, please review and merge if things look good. Thank you

@adamsitnik
Copy link
Member

macOS lane to confirm it is not related to changes here

done

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @naricc !

Before I hit the merge button, could you please provide some simple example of benefits of this feature? I am not familiar with this concept (yet)

@naricc
Copy link
Author

naricc commented Jul 17, 2020

@adamsitnik So, the benefit is primarily if you want to make a change to the runtime (whether that is mono, or clr, or whatever) and measure some benchmark results against that change. It's very easy to make the changes to the runtime and produce a new runtime pack.

With out this option it's very hard to make changes to the runtime and actually have the benchmarks use the changed version. You could in principle package the changed runtime into a dotnet host that uses the runtime you just built, but it's not a simple process.

@naricc
Copy link
Author

naricc commented Jul 17, 2020

@adamsitnik

Or, to put it another way, runtime packs are how we can point a project at a specific runtime with out going through the laborious process of packaging that runtime into a dotnet host.

@adamsitnik
Copy link
Member

runtime packs are how we can point a project at a specific runtime with out going through the laborious process of packaging that runtime into a dotnet host.

this is what I needed, thanks!

@adamsitnik adamsitnik merged commit 13ee8be into dotnet:master Jul 17, 2020
@adamsitnik
Copy link
Member

@naricc this build should produce 0.12.1.1402 package within 30-40 mintues

@SamMonoRT
Copy link
Member

Thank you @naricc and @adamsitnik for getting this in. Getting regular perf numbers will go a long way in improving what we ship to customers.

@AndreyAkinshin AndreyAkinshin added this to the v0.12.2 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants