-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Runtime Pack option #1501
Conversation
@adamsitnik (I can't actually add reviewers) |
@adamsitnik - is it possible to kick off a re-run of the BenchmarkDotNet - macOS lane to confirm it is not related to changes here. Also, if you have a moment, please review and merge if things look good. Thank you |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @naricc !
Before I hit the merge button, could you please provide some simple example of benefits of this feature? I am not familiar with this concept (yet)
@adamsitnik So, the benefit is primarily if you want to make a change to the runtime (whether that is mono, or clr, or whatever) and measure some benchmark results against that change. It's very easy to make the changes to the runtime and produce a new runtime pack. With out this option it's very hard to make changes to the runtime and actually have the benchmarks use the changed version. You could in principle package the changed runtime into a dotnet host that uses the runtime you just built, but it's not a simple process. |
Or, to put it another way, runtime packs are how we can point a project at a specific runtime with out going through the laborious process of packaging that runtime into a dotnet host. |
this is what I needed, thanks! |
@naricc this build should produce |
Thank you @naricc and @adamsitnik for getting this in. Getting regular perf numbers will go a long way in improving what we ship to customers. |
This adds an option to specify a custom runtime pack (currently only used by wasm, but in principle useful for other net5.0 appolications). This is used to run against a custom built net5.0 runtime.