Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots with a double dash (--) in the names (#1183) #1212

Merged
merged 5 commits into from
Aug 3, 2019
Merged

Plots with a double dash (--) in the names (#1183) #1212

merged 5 commits into from
Aug 3, 2019

Conversation

marcnet80
Copy link
Contributor

@dnfclas
Copy link

dnfclas commented Jul 24, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AndreyAkinshin
Copy link
Member

@marcnet80 I think, it will be better to use - in this case instead of -Default-. When we don't have any parameters, Default doesn't make any sense here, but it increases the length of the file name.

@AndreyAkinshin AndreyAkinshin self-requested a review July 26, 2019 10:34
@AndreyAkinshin AndreyAkinshin self-requested a review August 3, 2019 12:34
@AndreyAkinshin AndreyAkinshin added this to the v0.11.6 milestone Aug 3, 2019
@AndreyAkinshin AndreyAkinshin merged commit 5d7c789 into dotnet:master Aug 3, 2019
@adamsitnik adamsitnik mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@marcnet80 @dnfclas @AndreyAkinshin @marcnet90