Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gRPC supported platforms doc into hosting services and calling services sections #21689

Merged
merged 7 commits into from
Mar 11, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 4, 2021

Split the gRPC supported platform doc into two sections: one for hosting services and another for calling services.

Internal previews:


@Rick-Anderson
Copy link
Contributor

Verified all new links.

@JamesNK JamesNK force-pushed the jamesnk/grpc-supported-platforms-v2 branch from 6e15028 to 204ae8f Compare March 5, 2021 02:46
@JamesNK JamesNK requested a review from Rick-Anderson March 5, 2021 02:48
@JamesNK
Copy link
Member Author

JamesNK commented Mar 5, 2021

@Rick-Anderson I've made some substantial changes and split a section into a new doc. Please re-review 🙏

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

@JamesNK JamesNK added the blocked label Mar 5, 2021
@JamesNK
Copy link
Member Author

JamesNK commented Mar 5, 2021

Looks good. Will wait until gRPC release before merging. Should be next week.

@Rick-Anderson Rick-Anderson marked this pull request as draft March 5, 2021 05:48
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.1

@JamesNK JamesNK force-pushed the jamesnk/grpc-supported-platforms-v2 branch from e9a0bef to ed4f620 Compare March 8, 2021 04:46
@JamesNK JamesNK merged commit 2a813f9 into main Mar 11, 2021
@JamesNK JamesNK deleted the jamesnk/grpc-supported-platforms-v2 branch March 11, 2021 02:10
@scottaddie scottaddie changed the title Improve gRPC supported platforms doc Split gRPC supported platforms doc into hosting services and calling services sections Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants