Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example with set extension methods to memory cache usage #20850

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Add example with set extension methods to memory cache usage #20850

merged 3 commits into from
Dec 8, 2020

Conversation

Tornhoof
Copy link
Contributor

@Tornhoof Tornhoof commented Dec 3, 2020

This adds an example without creating the MemoryCacheEntryOptions object.
Fixes #20849

@Rick-Anderson Rick-Anderson self-assigned this Dec 3, 2020
Rick-Anderson
Rick-Anderson approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The link is correct/tested. This is how it renders:
image

adamsitnik
adamsitnik approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Tornhoof !

@Rick-Anderson Rick-Anderson merged commit 70b82ae into dotnet:master Dec 8, 2020
@Rick-Anderson
Copy link
Contributor

@Tornhoof thanks for this important PR, much appreciated.

@Tornhoof Tornhoof deleted the ImprovedMemoryCacheUsage branch December 8, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

Assignees

@Rick-Anderson Rick-Anderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved MemoryCache Usage
3 participants
@Tornhoof @Rick-Anderson @adamsitnik