Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ANCM doc for 3.0 #14462

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Update ANCM doc for 3.0 #14462

merged 2 commits into from
Sep 24, 2019

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 21, 2019 •
edited by Rick-Anderson
Loading

Fixes #12843

Internal Review Topic 2.1 no or few changes
Internal 3.0 version

  • Whole-topic versioning.
  • For 3.0 updates:
    • A couple of link changes and an API reference update.
    • Changes for the default hosting model.

@halter73, should shirhatti look?

@guardrex
Update ANCM doc for 3.0
cf1f802 
Updates

Updates
@Rick-Anderson
Copy link
Contributor

@halter73 can you take a quick review of Internal 3.0 version
That's where all the changes are.

@Rick-Anderson
Copy link
Contributor

@halter73 can you take a quick review of Internal 3.0 version or recommend another reviewer?
That's where all the changes are.

halter73
halter73 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd definitely wait on @Tratcher though

@guardrex guardrex merged commit c5397f9 into master Sep 24, 2019
@guardrex guardrex deleted the guardrex/ancm-30 branch September 24, 2019 19:22
@guardrex guardrex mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@halter73 halter73 halter73 approved these changes

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ANCM doc for 3.0 (Generic Host)
4 participants
@guardrex @Rick-Anderson @halter73 @Tratcher